Skip to content

ci/release: implement trusted publishing#9237

Merged
neersighted merged 7 commits intopython-poetry:mainfrom
neersighted:release_revamp
Mar 25, 2024
Merged

ci/release: implement trusted publishing#9237
neersighted merged 7 commits intopython-poetry:mainfrom
neersighted:release_revamp

Conversation

@neersighted
Copy link
Copy Markdown
Member

Completely rewrite the release workflow. There are a couple key differences now:

  • Releases are triggered by GitHub releases; which can refer to an existing tag, or create one on the fly.
  • Credentials are no longer needed to perform a release, instead we use the PyPI trusted publishing flow.
  • The build and upload tasks are split to ensure the credentials are safeguarded.
  • Uploads require approval from one other maintainer (beyond the person who triggered the build).
  • We now also upload release artifacts to the GitHub release.

Note that PyPI will only accept uploads from the 'pypi' environment, triggered in this workflow file.

We now run GHA on tags.
@neersighted neersighted added the area/ci Related to CI/CD label Mar 25, 2024
@neersighted neersighted requested a review from abn March 25, 2024 16:17
Comment thread .github/workflows/release.yaml
Completely rewrite the release workflow. There are a couple key
differences now:
* Releases are triggered by GitHub releases; which can refer to an
  existing tag, or create one on the fly.
* Credentials are no longer needed to perform a release, instead we use
  the PyPI trusted publishing flow.
* The build and upload tasks are split to ensure the credentials are
  safeguarded.
* Uploads require approval from one other maintainer (beyond the person
  who triggered the build).

Note that PyPI will only accept uploads from the 'pypi' environment,
triggered in this workflow file.
Comment thread .github/workflows/release.yaml
@neersighted neersighted merged commit 739f18a into python-poetry:main Mar 25, 2024
@neersighted neersighted deleted the release_revamp branch March 25, 2024 17:51
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/ci Related to CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants