Fix Relative Links for Single Page Repositories#9533
Closed
reesehyde wants to merge 5 commits intopython-poetry:mainfrom
Closed
Fix Relative Links for Single Page Repositories#9533reesehyde wants to merge 5 commits intopython-poetry:mainfrom
reesehyde wants to merge 5 commits intopython-poetry:mainfrom
Conversation
Contributor
|
#9166 already fixes this |
Member
|
I finally merged #9166 so I think we can close this one. |
Contributor
Author
|
Ah I missed the open PR, thank y'all! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves:
just let me know if I need to make a Poetry issue!
Bug
Relative links on Single Page Repositories are not resolved correctly
Steps to Reproduce
For example, take this
pyproject.tomlto install DGL according to its single-page repo:Expected Behavior
Actual Behavior
Poetry tries to locate the
dgl-2.3.0+cu118-cp310-cp310-manylinux1_x86_64.whlfile at/cu118/repo.html/dgl-2.3.0+cu118-cp310-cp310-manylinux1_x86_64.whlinstead of/cu118/dgl-2.3.0+cu118-cp310-cp310-manylinux1_x86_64.whl