Remove "tests" package from sdist installation#120
Closed
kwshi wants to merge 2 commits into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
=======================================
Coverage 91.80% 91.80%
=======================================
Files 11 11
Lines 2391 2391
=======================================
Hits 2195 2195
Misses 196 196 Continue to review full report at Codecov.
|
|
It is a teeny bit disappointing this fix did not get merged in time for 0.7.1, released 2 hours ago. Hopefully it can be merged in time for any future 0.7.2? |
Contributor
Author
|
For reference, this PR was closed because I think the issue was fixed in 63b96f1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #69 (nice). Currently the tomlkit tests are included in the distribution via
packages, but that behavior is incorrect since it causesteststo be exposed (and installed!) as a module. We don't want that; we only wantteststo be included in the source distribution, so the more sensible configuration is to use theincludekey.Solution comes from this comment, as well as @abn's implementation of the same fix for Poetry.