Skip to content

Allow nursery creation in async yield fixtures#26

Merged
touilleMan merged 1 commit intopython-trio:masterfrom
touilleMan:async-yield-fixture-create-nursery
Jan 3, 2018
Merged

Allow nursery creation in async yield fixtures#26
touilleMan merged 1 commit intopython-trio:masterfrom
touilleMan:async-yield-fixture-create-nursery

Conversation

@touilleMan
Copy link
Member

Should closes #25

…nit in nursery (cause crash during teardown otherwise)
@touilleMan touilleMan mentioned this pull request Dec 19, 2017
@codecov
Copy link

codecov bot commented Dec 19, 2017

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   97.05%   97.05%           
=======================================
  Files           9        9           
  Lines         204      204           
  Branches       17       17           
=======================================
  Hits          198      198           
  Misses          5        5           
  Partials        1        1
Impacted Files Coverage Δ
pytest_trio/plugin.py 95.12% <100%> (-0.16%) ⬇️
pytest_trio/_tests/test_async_yield_fixture.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce66103...abe67d2. Read the comment docs.

@touilleMan
Copy link
Member Author

Not sure if we should merge this though (cf. error handling from within the coroutine started by the fixture's nursely)

@touilleMan touilleMan merged commit abe67d2 into python-trio:master Jan 3, 2018
@touilleMan touilleMan deleted the async-yield-fixture-create-nursery branch April 11, 2018 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add nursery fixture

1 participant