Merged
Conversation
Fixes python-triogh-9 Documentation in python-triogh-47
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 95.35% 96.75% +1.39%
==========================================
Files 11 13 +2
Lines 280 308 +28
Branches 26 30 +4
==========================================
+ Hits 267 298 +31
+ Misses 9 6 -3
Partials 4 4
Continue to review full report at Codecov.
|
This was referenced Jul 24, 2018
Merged
touilleMan
approved these changes
Jul 24, 2018
Member
touilleMan
left a comment
There was a problem hiding this comment.
This seems pretty good to me ;-)
Member
Author
|
Do you want to click merge, or is there something you think we should wait for...? (I did realize I didn't do release notes for this, but this next release is going to have a chunk of stuff so maybe it's better to write it all together?) |
Member
|
I"m heading to the europython right now so won't be able to do the merge
until tonight.
So go ahead and do the merge ;-)
Le mar. 24 juil. 2018 12:06, Nathaniel J. Smith <notifications@github.com>
a écrit :
… Do you want to click merge, or is there something you think we should wait
for...?
(I did realize I didn't do release notes for this, but this next release
is going to have a chunk of stuff so maybe it's better to write it all
together?)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#49 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADCjtfp45k0jWA5ojrJ3YD-7ND-nZDkGks5uJvGkgaJpZM4VagXg>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-9
Documentation in gh-47