Bump pytest from 4.5.0 to 4.6.1

[dependabot-preview]

Bumps pytest from 4.5.0 to 4.6.1.

Changelog

Sourced from pytest's changelog.

pytest 4.6.1 (2019-06-02)

Bug Fixes

• #5354: Fix pytest.mark.parametrize when the argvalues is an iterator.
• #5358: Fix assertion rewriting of all() calls to deal with non-generators.

pytest 4.6.0 (2019-05-31)

Important

The 4.6.X series will be the last series to support Python 2 and Python 3.4.

For more details, see our Python 2.7 and 3.4 support plan.

Features

• #4559: Added the junit_log_passing_tests ini value which can be used to enable or disable logging of passing test output in the Junit XML file.
• #4956: pytester's testdir.spawn uses tmpdir as HOME/USERPROFILE directory.
• #5062: Unroll calls to all to full for-loops with assertion rewriting for better failure messages, especially when using Generator Expressions.
• #5063: Switch from pkg_resources to importlib-metadata for entrypoint detection for improved performance and import time.
• #5091: The output for ini options in --help has been improved.
• #5269: pytest.importorskip includes the ImportError now in the default reason.
• #5311: Captured logs that are output for each failing test are formatted using the ColoredLevelFormatter.
• #5312: Improved formatting of multiline log messages in Python 3.

Bug Fixes

• #2064: The debugging plugin imports the wrapped Pdb class (--pdbcls) on-demand now.
• #4908: The pytest_enter_pdb hook gets called with post-mortem (--pdb).
• #5036: Fix issue where fixtures dependent on other parametrized fixtures would be erroneously parametrized.
• #5256: Handle internal error due to a lone surrogate unicode character not being representable in Jython.
• #5257: Ensure that sys.stdout.mode does not include 'b' as it is a text stream.
• #5278: Pytest's internal python plugin can be disabled using -p no:python again.
• #5286: Fix issue with disable_test_id_escaping_and_forfeit_all_rights_to_community_support option not working when using a list of test IDs in parametrized tests.
• #5330: Show the test module being collected when emitting PytestCollectionWarning messages for test classes with __init__ and __new__ methods to make it easier to pin down the problem.
• #5333: Fix regression in 4.5.0 with --lf not re-running all tests with known failures from non-selected tests.

Improved Documentation

• #5250: Expand docs on use of setenv and delenv with monkeypatch.

Commits

• abb853f Preparing release version 4.6.1
• 8208a37 Merge pull request #5361 from asottile/backport_5360
• f078984 Fix all() unroll for non-generators/non-list comprehensions (#5360)
• dba62f8 [4.6] Fix pytest.mark.parametrize when the argvalue is an iterator (#5357)
• f7bf914 Fix pytest.mark.parametrize when the argvalue is an iterator
• 917195e Merge pull request #5350 from asottile/release-4.6.0
• e7cd00a Preparing release version 4.6.0
• 693c3b7 Merge pull request #5349 from asottile/mm
• fb3ae5e Merge remote-tracking branch 'origin/master' into mm
• c8d23c2 logging: Improve formatting of multiline message (#5312)
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
• @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

• Update frequency (including time of day and day of week)
• Automerge options (never/patch/minor, and dev/runtime dependencies)
• Pull request limits (per update run and/or open at any time)
• Out-of-range updates (receive only lockfile updates, if desired)
• Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

[njsmith]

What the heck

My first thought is actually that pytest's assertion rewriting code picked up a new bug...

[njsmith]

I can't reproduce it locally either?

[njsmith]

@blueyed on freenode #pylib pointed me to pytest-dev/pytest#5370. The error is different, but if there are known to be bugs in pytest's current handling of nested comprehensions then that does make it seem more likely...

[njsmith]

aaaaand now it's failing consistently for me locally, even when I revert back to pytest 4.5.0

what the HECK

[blueyed]

aaaaand now it's failing consistently for me locally, even when I revert back to pytest 4.5.0

find -name "*.pyc" -delete ?

[blueyed]

My first thought is actually that pytest's assertion rewriting code picked up a new bug...

More likely a pytest issue.

[njsmith]

find -name "*.pyc" -delete

I ran it 3 times in a row with pytest 4.5.0 and it failed all 3 times. Then I deleted *-PYTEST.pyc, and ran it 3 times in a row, and it didn't fail at all. So that strongly suggests that .pycs are implicated somehow.

Then I switched back to pytest 4.6.1, and... now I can't get it to fail locally, again. I tried deleting all .pycs and several other things, and it won't fail.

Also, based on the debug output I added to the CI, to print the values before we do the assert, the assertion failure is actually correct. That suggests that whatever is going wrong, it isn't happening on the assert line itself. (Or I guess it could be that pytest 4.5.0 and earlier are somehow mishandling the assert to make it accidentally pass?)

[njsmith]

Ah-hah! When I was attempting to reproduce it this time, I accidentally upgraded to 4.6.2, which includes a fix for assert + comprehensions: pytest-dev/pytest#5373

If I go back to 4.6.1 and delete .pyc files, then I can reproduce it locally.

So it sounds like we were just bitten by the same bug as everyone else, and the solution is to skip 4.6.1.

[njsmith]

@dependabot ignore this patch version

[dependabot-preview]

OK, I won't notify you about version 4.6.1 again, unless you re-open this PR or update to a 4.6.1 release yourself.