make trio.Process.returncode automatically update itself as needed#1514
Merged
oremanj merged 1 commit intopython-trio:masterfrom May 12, 2020
Merged
make trio.Process.returncode automatically update itself as needed#1514oremanj merged 1 commit intopython-trio:masterfrom
oremanj merged 1 commit intopython-trio:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1514 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 107 107
Lines 13254 13264 +10
Branches 1006 1006
=======================================
+ Hits 13211 13221 +10
Misses 28 28
Partials 15 15
|
njsmith
added a commit
to njsmith/trio
that referenced
this pull request
May 23, 2020
python-triogh-1514 introduced a race condition in this test: now if the process runs quickly enough, the returncode might have magically become non-None before we check it. Example failure: https://travis-ci.org/github/python-trio/trio/jobs/690291915 There are other tests that check the 'p.returncode is None' case (e.g. test_auto_update_returncode), so we can just delete this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1315