In KqueueIOManager, close the force-wakeup fd#1623
Merged
pquentin merged 1 commit intopython-trio:masterfrom Jun 16, 2020
Merged
In KqueueIOManager, close the force-wakeup fd#1623pquentin merged 1 commit intopython-trio:masterfrom
pquentin merged 1 commit intopython-trio:masterfrom
Conversation
This small bug was introduced in python-triogh-1551 Fixes python-triogh-1621
njsmith
force-pushed
the
close-kqueue-force-wakeup
branch
from
a5a353a to
1d9d0ca
Compare
Codecov Report
@@ Coverage Diff @@
## master #1623 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 110 110
Lines 13859 13860 +1
Branches 1062 1062
=======================================
+ Hits 13817 13818 +1
Misses 27 27
Partials 15 15
|
pquentin
approved these changes
Jun 16, 2020
Member
pquentin
left a comment
pquentin
left a comment
There was a problem hiding this comment.
Thanks, that fixes the warnings I was seeing on macOS with PYTHONDEVMODE=1. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small bug was introduced in gh-1551
Fixes gh-1621