Fix crash due to runtime import of typing_extensions#2507
Merged
A5rocks merged 1 commit intopython-trio:masterfrom Dec 25, 2022
Merged
Fix crash due to runtime import of typing_extensions#2507A5rocks merged 1 commit intopython-trio:masterfrom
typing_extensions#2507A5rocks merged 1 commit intopython-trio:masterfrom
Conversation
typing_extensions doesn't presently need to be a runtime dependency.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2507 +/- ##
==========================================
- Coverage 97.98% 93.51% -4.48%
==========================================
Files 118 118
Lines 16327 16327
Branches 3156 3156
==========================================
- Hits 15998 15268 -730
- Misses 266 954 +688
- Partials 63 105 +42
|
Member
Author
|
the test suite timeout on CPython 3.9 on Windows x86-64 seems unrelated and likely just needs a rerun |
Contributor
|
Looks good! Why didn't our test suite catch this? Do we need to separate out typing dependencies (mypy depends on |
Member
Author
|
yep, looks like it. see Lines 124 to 127 in 4e7f21e while in this case this bug would have been automatically caught if MyPy was not in the test dependencies, the same bug can always still go uncaught in the future if a package required for testing starts depending on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi!
#2502 added a runtime dependency on
typing_extensionsbut did not update the packaging config to specify this dependency.presently no runtime features of
typing_extensionsare being used, so it does not need to be a dependency at runtime.(I have not included a changelog entry here since #2502 did not either and the bug this fixes was never user-facing.)