Skip to content

Bump towncrier from 22.8.0 to 22.12.0 #2511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
A5rocks merged 1 commit into from
Feb 8, 2023
Merged

Bump towncrier from 22.8.0 to 22.12.0 #2511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions docs-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,7 @@ sphinxcontrib-serializinghtml==1.1.5
# via sphinx
sphinxcontrib-trio==1.1.2
# via -r docs-requirements.in
tomli==2.0.1
# via towncrier
Comment on lines -87 to -88
Copy link
Contributor

@A5rocks A5rocks Dec 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how this is possible for non 3.11 Python.

Looking at towncrier, it looks like tomli will be installed for non 3.11 Python but somehow isn't being locked?

Copy link
Contributor

@A5rocks A5rocks Dec 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, so we simply need to check pip-compile in the linting workflow? Should be simple enough.

Copy link
Contributor

@A5rocks A5rocks Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do this in a followup PR

towncrier==22.8.0
towncrier==22.12.0
# via -r docs-requirements.in
urllib3==1.26.14
# via requests
Expand Down