Skip to content

Check pip-compile and commit autoformatter changes#2559

Merged
A5rocks merged 2 commits intopython-trio:masterfrom
A5rocks:auto-pip-freeze
Feb 10, 2023
Merged

Check pip-compile and commit autoformatter changes#2559
A5rocks merged 2 commits intopython-trio:masterfrom
A5rocks:auto-pip-freeze

Conversation

@A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Feb 8, 2023

I'm not sure having a commit afterwards is the best behavior for if someone is rapidly iterating, but this specifically would make dependabot PRs nicer to deal with. (dependabot has a nasty habit of removing things from the lockfile: #2511 (comment))

https://github.com/A5rocks/trio/actions/runs/4120613215/jobs/7115511631 proof this works

(I think, after this, the next step is adding an action that enables the auto-merge feature on any PR dependabot makes. After that: make dependabot update our github actions (ie @actions/checkout which ATM is out of date))

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #2559 (ed33f1b) into master (de6e018) will not change coverage.
The diff coverage is n/a.

❗ Current head ed33f1b differs from pull request most recent head 363f266. Consider uploading reports for the commit 363f266 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2559   +/-   ##
=======================================
  Coverage   92.45%   92.45%           
=======================================
  Files         118      118           
  Lines       16345    16345           
  Branches     3155     3155           
=======================================
  Hits        15112    15112           
  Misses       1104     1104           
  Partials      129      129           

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@A5rocks
Copy link
Contributor Author

A5rocks commented Feb 9, 2023

I was searching through history on the gitter channel and it turns out this has been mentioned before and turned down as too much a burden on a developer: https://gitter.im/python-trio/general?at=5d426fcee2802b6790a860be

I could make this use a specific PR comment to trigger instead. Any opinions? (ie autoformat on its own line?)

@pquentin
Copy link
Member

pquentin commented Feb 9, 2023

Or maybe you could only apply this on dependabot PRs?

Additionally, commit autoformatter changes for Dependabot
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

@A5rocks A5rocks merged commit 350d0bf into python-trio:master Feb 10, 2023
@A5rocks A5rocks deleted the auto-pip-freeze branch February 10, 2023 23:47
@A5rocks
Copy link
Contributor Author

A5rocks commented Feb 11, 2023

I had to commit b1fbbd3 (and a few other things) to make this work on dependabot PRs. (actually, this still fails... https://github.com/python-trio/trio/actions/runs/4149501153/jobs/7178493177#step:6:22 ugh)

I'm not so sure that's secure; it certainly seems like a bad idea. Are these secure?

Looking at the docs (https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions) says that this will only grant it if the actor has write permissions (or if we enabled a setting we probably didn't), so I suppose we're fine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants