Rework packaging to use Poetry instead.#2595
Closed
Fuyukai wants to merge 3 commits intopython-trio:masterfrom
Closed
Rework packaging to use Poetry instead.#2595Fuyukai wants to merge 3 commits intopython-trio:masterfrom
Fuyukai wants to merge 3 commits intopython-trio:masterfrom
Conversation
Merged
Member
Author
|
Likely not going to happen, and this PR predates several major organisational changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does several things:
setup.pyand replace it with a Poetry-basedpyproject.toml.Questions I invisige might be asked:
Q: Why Poetry and not ?
A: I only know Poetry and this is my PR.
Q: Why
srclayout?A: It has less shenanigans with PYTHONPATH. Also, it's better to do it now and break history (well, git can see the renames but github, in its infinite usability, cannot?) than do a bunch of work on the project and eventually move it over in the future.
Q: Why separate out tests?
A: I couldn't find an answer to "how to make pytest use conftest for installed package tests" in 5 minutes so I just spent the effort to separate them out instead. Also, it annoys me on some level that every trio download includes a few extra kilobytes of tests for no reason.
TODO: