Skip to content

Fix tokenless uploads by hardcoding token... #2672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
A5rocks merged 1 commit into from
Jun 26, 2023
Merged

Fix tokenless uploads by hardcoding token... #2672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ jobs:
uses: codecov/codecov-action@v3
with:
directory: empty
name: 'Windows (${{ matrix.python }}, ${{ matrix.arch }}${{ matrix.extra_name }})'
token: 87cefb17-c44b-4f2f-8b30-1fff5769ce46
Copy link
Member

@webknjaz webknjaz Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@A5rocks from the link you provided:

A malicious actor would be able to upload incorrect or misleading coverage reports to a specific repository if they have access to your upload token, but would not be able to pull down source code or make any code changes.

So with that in mind, I'd suggest using repository secrets to store an actual token instead of displaying it publicly.

Here, it'd look like

Suggested change
token: 87cefb17-c44b-4f2f-8b30-1fff5769ce46
token: ${{ secrets.CODECOV_TOKEN }}

and it'd be sanitized in the logs, addressing said problem.

Though, somebody should probably revoke/reset the token exposed here. I suppose only @njsmith can add repo secrets?

name: Windows (${{ matrix.python }}, ${{ matrix.arch }}${{ matrix.extra_name }})
flags: Windows,${{ matrix.python }}

Ubuntu:
Expand Down Expand Up @@ -131,7 +132,8 @@ jobs:
uses: codecov/codecov-action@v3
with:
directory: empty
name: 'Ubuntu (${{ matrix.python }}${{ matrix.extra_name }})'
token: 87cefb17-c44b-4f2f-8b30-1fff5769ce46
name: Ubuntu (${{ matrix.python }}${{ matrix.extra_name }})
flags: Ubuntu,${{ matrix.python }}

macOS:
Expand Down Expand Up @@ -166,7 +168,8 @@ jobs:
uses: codecov/codecov-action@v3
with:
directory: empty
name: 'macOS (${{ matrix.python }})'
token: 87cefb17-c44b-4f2f-8b30-1fff5769ce46
name: macOS (${{ matrix.python }})
flags: macOS,${{ matrix.python }}

# https://github.com/marketplace/actions/alls-green#why
Expand Down