Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2698 +/- ##
=======================================
Coverage 98.89% 98.89%
=======================================
Files 113 113
Lines 16490 16490
Branches 3000 3000
=======================================
Hits 16307 16307
Misses 126 126
Partials 57 57
|
A5rocks
approved these changes
Jul 13, 2023
Contributor
A5rocks
left a comment
A5rocks
left a comment
There was a problem hiding this comment.
Looks alright to me! I'm a bit concerned by the amount of linters we have to run now, but I suppose this might be where stuff like pre-commit comes in (... my opinion on that is still TBD)
Member
Author
|
Yeah, this starts getting into silly territory when you're launching it from a messy shell script - but I'm used to running with a million linters and autofixers and IME it ups my productivity quite a bit and reduces the amount of code review and CI runs needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2694
Found one typo! In a line I wrote of course 😇