Closed
Conversation
Codecov Report
Additional details and impacted files
|
This was referenced Aug 3, 2023
Closed
Member
Author
|
don't bother merging into this branch, it inverting the black/whitelist in |
… issues found in 129 source files works again
# Conflicts: # pyproject.toml # trio/_core/_traps.py # trio/_subprocess.py # trio/_subprocess_platform/kqueue.py # trio/_subprocess_platform/windows.py # trio/_tests/verify_types.json
Member
Author
|
Superseded by #2763 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've had this branch as a development branch locally to check compatibility between my typing PRs, and be able to quickly write mostly-fine types without waiting for reviews. But with @TeamSpen210 also working on types, I figured I should push this so we don't duplicate work. But feel free to grab stuff from it!
Don't bother reviewing this one, at least not in detail or in full. It'll likely be full of merge conflicts and failing tests and the like as well. I'm pulling out one or a few files at a time, cleaning them up, and opening separate PRs.