Skip to content

Add type annotations to _depreciate.py#2722

Closed
CoolCat467 wants to merge 3 commits intopython-trio:masterfrom
CoolCat467:typing-_deprecate
Closed

Add type annotations to _depreciate.py#2722
CoolCat467 wants to merge 3 commits intopython-trio:masterfrom
CoolCat467:typing-_deprecate

Conversation

@CoolCat467
Copy link
Member

This PR adds type annotations to _depreciate.py.

With mypy, everything is good except for one error in deprecated_alias at the moment that I'm not sure how to handle.

I would love feedback and any comments on how this could be improved to be more accurate.

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #2722 (a796fff) into master (cf1f3c7) will decrease coverage by 7.41%.
The diff coverage is 92.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2722      +/-   ##
==========================================
- Coverage   98.89%   91.48%   -7.41%     
==========================================
  Files         113      113              
  Lines       16600    16612      +12     
  Branches     3014     2663     -351     
==========================================
- Hits        16417    15198    -1219     
- Misses        126     1269    +1143     
- Partials       57      145      +88     
Files Changed Coverage Δ
trio/_deprecate.py 97.64% <92.85%> (-2.36%) ⬇️

... and 45 files with indirect coverage changes

@TeamSpen210
Copy link
Contributor

Hmm, this is a little awkward - I just opened a PR for this same thing (#2719) yesterday.

@A5rocks A5rocks added the typing Adding static types to trio's interface label Jul 29, 2023
@jakkdl
Copy link
Member

jakkdl commented Jul 30, 2023

Hmm, this is a little awkward - I just opened a PR for this same thing (#2719) yesterday.

I vote for closing this one and focusing on #2719, @CoolCat467 would be lovely if you ran a diff against your changes and reviewed it.

Feel free to reopen if you disagree, but with the PR list having 9 open typing PRs I think it good to thin it out a bit.

@jakkdl jakkdl closed this Jul 30, 2023
@CoolCat467 CoolCat467 deleted the typing-_deprecate branch August 24, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

typing Adding static types to trio's interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants