Add type annotations to _depreciate.py#2722
Closed
CoolCat467 wants to merge 3 commits intopython-trio:masterfrom
Closed
Add type annotations to _depreciate.py#2722CoolCat467 wants to merge 3 commits intopython-trio:masterfrom
_depreciate.py#2722CoolCat467 wants to merge 3 commits intopython-trio:masterfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2722 +/- ##
==========================================
- Coverage 98.89% 91.48% -7.41%
==========================================
Files 113 113
Lines 16600 16612 +12
Branches 3014 2663 -351
==========================================
- Hits 16417 15198 -1219
- Misses 126 1269 +1143
- Partials 57 145 +88
|
Contributor
|
Hmm, this is a little awkward - I just opened a PR for this same thing (#2719) yesterday. |
Member
I vote for closing this one and focusing on #2719, @CoolCat467 would be lovely if you ran a diff against your changes and reviewed it. Feel free to reopen if you disagree, but with the PR list having 9 open typing PRs I think it good to thin it out a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds type annotations to
_depreciate.py.With mypy, everything is good except for one error in
deprecated_aliasat the moment that I'm not sure how to handle.I would love feedback and any comments on how this could be improved to be more accurate.