Closed
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2726 +/- ##
==========================================
- Coverage 98.89% 98.88% -0.02%
==========================================
Files 113 113
Lines 16600 16605 +5
Branches 3014 3015 +1
==========================================
+ Hits 16417 16420 +3
- Misses 126 127 +1
- Partials 57 58 +1
|
Contributor
|
Oh geh, another overlap with #2719! Mind giving that a look-over? Given you've done the same process yourself, you should probably have opinions on how it should be! |
Member
|
Closing this one to focus on #2719 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds type annotations to
_util.pyI added a bunch of
Anyannotations forgeneric_function, I can't think of anything better at the moment.I would love feedback and any comments on how this could be improved to be more accurate.