Add types to core._thread_cache#2741
Merged
TeamSpen210 merged 7 commits intopython-trio:masterfrom Aug 8, 2023
Merged
Conversation
Closed
41 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2741 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 113 113
Lines 16685 16687 +2
Branches 3025 3025
=======================================
+ Hits 16503 16505 +2
Misses 125 125
Partials 57 57
|
Contributor
Author
|
This needs |
A5rocks
approved these changes
Aug 6, 2023
Contributor
A5rocks
left a comment
A5rocks
left a comment
There was a problem hiding this comment.
Looks fine, minor comment.
(the Optional[T] to T | None took a bit of time to parse xdd)
TeamSpen210
changed the title
core._thread cachecore._thread_cache
jakkdl
approved these changes
Aug 6, 2023
TeamSpen210
force-pushed
the
type_thread_cache
branch
from
ff33bb5 to
69f2682
Compare
A5rocks
approved these changes
Aug 8, 2023
Contributor
A5rocks
left a comment
A5rocks
left a comment
There was a problem hiding this comment.
I still think this is good, feel free to merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds types to this module.