type _io_epoll and _io_kqueue#2743
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2743 +/- ##
=======================================
Coverage 98.90% 98.91%
=======================================
Files 113 113
Lines 16686 16713 +27
Branches 3025 3030 +5
=======================================
+ Hits 16504 16531 +27
Misses 125 125
Partials 57 57
|
|
I don't think writing a test for the decorator logic in |
| @@ -122,6 +159,9 @@ def gen_public_wrappers_source(source_path: Path, lookup_path: str) -> str: | |||
| # Create the function definition including the body | |||
| func = astor.to_source(method, indent_with=" " * 4) | |||
There was a problem hiding this comment.
If it's possible to fix the type annotation formatting that would be great but if not I understand
There was a problem hiding this comment.
I don't think it's worth the effort, feel free to attack in a separate PR if you want to.
A possibly better fix is enabling Black on the file and changing how it's checked.
There was a problem hiding this comment.
Could make gen_exports call black after generating even. But definitely a separate PR.
This way they only import the things they actually use.
|
Awesome stuff @TeamSpen210 - I would probably not have bothered myself but this is much much nicer and means we can remove it as an exception from |
|
good stuff, thanks @TeamSpen210! |
4 participants
Also generates a type guard in
_generated_io_*so they don't raise errors if checked in other ways thanmypy -m trio