Fix type errors introduced when #2696 and #2700 were merged#2788
Merged
richardsheridan merged 4 commits intomasterfrom Sep 3, 2023
Merged
Fix type errors introduced when #2696 and #2700 were merged#2788richardsheridan merged 4 commits intomasterfrom
richardsheridan merged 4 commits intomasterfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2788 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 113 113
Lines 16917 16919 +2
Branches 3049 3050 +1
=======================================
+ Hits 16739 16741 +2
Misses 123 123
Partials 55 55
|
CoolCat467
changed the title
A5rocks
reviewed
Sep 3, 2023
A5rocks
approved these changes
Sep 3, 2023
Contributor
A5rocks
left a comment
A5rocks
left a comment
There was a problem hiding this comment.
Changes seem fine, though nitpicks obviously...
I'll let someone else merge this (this isn't like emergency-level priority or anything :^)
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the type errors introduced in #2696 and #2700, while leaving the multierror fixes for #2787.