Add types to _signals, test_signals#2794
Merged
jakkdl merged 5 commits intopython-trio:masterfrom Sep 13, 2023
Merged
Conversation
Convert this helper to a function to allow that.
Closed
41 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2794 +/- ##
=======================================
Coverage 98.95% 98.95%
=======================================
Files 115 115
Lines 17003 17011 +8
Branches 3045 3045
=======================================
+ Hits 16825 16833 +8
Misses 123 123
Partials 55 55
|
CoolCat467
approved these changes
Sep 12, 2023
Member
CoolCat467
left a comment
There was a problem hiding this comment.
Looks good to me. If anything, the change removing _pending_signal_count could potentially cause issues if people are using this function even though it basically says not to because it was only there for the tests, but I think this is an acceptable change because:
- People shouldn't be using said function anyways
- Making it a separate function that isn't publicly exposed is a better solution for the tests than having it be a class function that technically could exposed
A5rocks
approved these changes
Sep 12, 2023
Contributor
A5rocks
left a comment
There was a problem hiding this comment.
Looks like a pretty simple file to type. Essentially no comments!
jakkdl
approved these changes
Sep 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is fairly straightforward, but I did extract a test helper method into a function. This allows
open_signal_receiver()to be typed as producing anAsyncIterator, keepingSignalReceiverinternal.