add tests and coverage ignores for testing/_fake_net to reach full coverage #2852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2852 +/- ##
==========================================
+ Coverage 99.18% 99.51% +0.33%
==========================================
Files 115 115
Lines 17551 17683 +132
Branches 3149 3172 +23
==========================================
+ Hits 17408 17598 +190
+ Misses 99 56 -43
+ Partials 44 29 -15
|
CoolCat467
approved these changes
Nov 4, 2023
Member
CoolCat467
left a comment
CoolCat467
left a comment
There was a problem hiding this comment.
This all makes sense, I approve.
TeamSpen210
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing #2820 I noticed the bad shape of
_fake_net. While it's only for internal use, and unclear if it's ever going to be added to the public API, I figured it'd be worth cleaning it up a bit and fix coverage so as not to drag everything else down.