Skip to content

Address PyPy flakiness in test_for_leaking_fds #2888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
A5rocks merged 1 commit into from
Nov 27, 2023
Merged

Address PyPy flakiness in test_for_leaking_fds #2888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/trio/_tests/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import gc
import os
import random
import signal
Expand Down Expand Up @@ -620,6 +621,8 @@ async def test_run_process_background_fail() -> None:
reason="requires a way to iterate through open files",
)
async def test_for_leaking_fds() -> None:
gc.collect() # address possible flakiness on PyPy

starting_fds = set(SyncPath("/dev/fd").iterdir())
await run_process(EXIT_TRUE)
assert set(SyncPath("/dev/fd").iterdir()) == starting_fds
Expand Down