Cleanup of tests, and removal of _assert_raises#2890
Merged
Zac-HD merged 4 commits intopython-trio:masterfrom Nov 28, 2023
Merged
Cleanup of tests, and removal of _assert_raises#2890Zac-HD merged 4 commits intopython-trio:masterfrom
Zac-HD merged 4 commits intopython-trio:masterfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2890 +/- ##
==========================================
- Coverage 99.54% 99.54% -0.01%
==========================================
Files 115 115
Lines 17660 17623 -37
Branches 3165 3153 -12
==========================================
- Hits 17580 17543 -37
Misses 52 52
Partials 28 28
|
A5rocks
reviewed
Nov 27, 2023
This reverts commit 153d700.
Member
Author
|
The coverage change is from mypy stuff in test_exports, idk why it's popping up here but should probably get some |
Zac-HD
approved these changes
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements to tests, including removal of
_assert_raises, pulled out from #2886