Add PosArgT typing to trio.run#3022
Conversation
f6e62ed to
e668396
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3022 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 120 120
Lines 17865 17865
Branches 3216 3216
=======================================
Hits 17800 17800
Misses 46 46
Partials 19 19
|
Zac-HD
left a comment
There was a problem hiding this comment.
Looks good to me!
Should we consider moving over some of the trio-typing test suite, since apparently that catches some issues that the trio tests don't?
TeamSpen210
left a comment
There was a problem hiding this comment.
Must have been missed, yes.
A5rocks
left a comment
There was a problem hiding this comment.
Maybe add a type test.
Feel free to merge this whether or not you add one though.
There's not much that's worth adapting, I don't think we want to adapt their method of running internal mypy functions, so it would consist of copying and adapting the test-data. But we already cover most everything:
The only things left were |
I noticed this when going through the trio-typing test suite. I don't see any reason why this would've been intentionally skipped in #2881, so I suspect it just got missed?