Skip to content

Use 3.12 for formatting check#3049

Merged
A5rocks merged 4 commits intopython-trio:mainfrom
A5rocks:upgraded-formatting-python
Aug 4, 2024
Merged

Use 3.12 for formatting check#3049
A5rocks merged 4 commits intopython-trio:mainfrom
A5rocks:upgraded-formatting-python

Conversation

@A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Aug 2, 2024

Fixes #2681. Not using the lowest version means:

  • this runs faster because Python is faster now
  • it's clear that this doesn't need to be the lowest supported version.

This works now because of the switch to uv which has a --python-version flag.

@codecov
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (20f9291) to head (f11f044).
Report is 176 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3049   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files         120      120           
  Lines       17832    17832           
  Branches     3204     3204           
=======================================
  Hits        17767    17767           
  Misses         46       46           
  Partials       19       19           

Copy link
Member

@CoolCat467 CoolCat467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good provided that the CI succeeds

@CoolCat467
Copy link
Member

Shouldn't we also update no test-requirements while we are at it?

@A5rocks
Copy link
Contributor Author

A5rocks commented Aug 2, 2024

Shouldn't we also update no test-requirements while we are at it?

I think its python version isn't related to the formatting check. (and it can be upgraded whenever, I forgot the motivation behind it...)

Actually, it's probably better to be < 3.11 because otherwise ExceptionGroup is built in.

@A5rocks A5rocks merged commit 2d0824f into python-trio:main Aug 4, 2024
@A5rocks A5rocks deleted the upgraded-formatting-python branch August 8, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

python version for CI formatting check

2 participants