Enable mypy and disable jedi on PyPy#3075
Merged
A5rocks merged 1 commit intopython-trio:mainfrom Aug 30, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3075 +/- ##
==========================================
- Coverage 99.61% 99.61% -0.01%
==========================================
Files 121 121
Lines 17880 17878 -2
Branches 3214 3213 -1
==========================================
- Hits 17812 17810 -2
Misses 48 48
Partials 20 20
|
CoolCat467
approved these changes
Aug 29, 2024
Member
CoolCat467
left a comment
CoolCat467
left a comment
There was a problem hiding this comment.
Looks good as far as I can tell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2885
I remember jedi being somewhat flaky on PyPy so this should fix that.