Remove 2nd client hello post openssl 1.1.1 bug workaround #3097
+1
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3097 +/- ##
==========================================
- Coverage 99.58% 99.58% -0.01%
==========================================
Files 121 121
Lines 18167 18166 -1
Branches 3268 3268
==========================================
- Hits 18092 18091 -1
Misses 52 52
Partials 23 23
|
A5rocks
reviewed
Sep 29, 2024
Co-authored-by: A5rocks <git@helvetica.moe>
A5rocks
approved these changes
Oct 1, 2024
Contributor
A5rocks
left a comment
A5rocks
left a comment
There was a problem hiding this comment.
I don't know enough about this to say whether it's correct but looks good to me!
Member
|
ubuntu 18.06, as mentioned in the comment, reached EOL at 2023-05-31. So yeah I'm guessing it'll be fine |
Member
Author
|
Going to merge this soon unless anyone has any additional concerns, consensus seems to be that removing duplicate should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, we remove a workaround for a bug in OpenSSL 1.1.1 with DTLS
ClientHellos being eaten. There is a comment noting that it should be safe to remove this workaround in 2024 or so, so the time is neigh!