gh-3108: Avoid materializing f_locals for KI protection#3110
gh-3108: Avoid materializing f_locals for KI protection#3110graingert merged 39 commits intopython-trio:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3110 +/- ##
===================================================
+ Coverage 99.58714% 99.62377% +0.03662%
===================================================
Files 121 122 +1
Lines 18166 18340 +174
Branches 3268 3281 +13
===================================================
+ Hits 18091 18271 +180
+ Misses 52 47 -5
+ Partials 23 22 -1
|
… code objects instead
e04b3d8 to
5d51c56
Compare
…ed to fix the use of Any
d44f023 to
ec30d7b
Compare
A5rocks
left a comment
There was a problem hiding this comment.
Plenty of nitpicks or me being confused; please don't assume I know what I'm doing with these comments. If the question doesn't make sense, it's cause I don't understand and not some weird encoded question.
Co-authored-by: EXPLOSION <git@helvetica.moe>
Co-Authored-By: oremanj <oremanj@gmail.com>
A5rocks
left a comment
There was a problem hiding this comment.
A bunch of really minor comments. This could merge as is without any changes IMO.
|
Nevermind, I was thinking about whether a deprecation is possible but it isn't because the problem is functions having ki protection only sometimes. |
|
pre-commit.ci autofix |
A5rocks
left a comment
There was a problem hiding this comment.
Just to be explicit, since all my comments were fixed and all my questions answered.
CoolCat467
left a comment
There was a problem hiding this comment.
As far as I can tell, this looks pretty great
Fixes #3108
Fixes #2670
In this pull request, we avoid materializing
f_localsby using weak references to code objects instead.