Add Task.custom_sleep_data#616
Merged
oremanj merged 3 commits intopython-trio:masterfrom Aug 21, 2018
Merged
Conversation
For discussion see: python-trio#586 (comment)
This replaces the gross hack where we mutated Task._abort_func
Codecov Report
@@ Coverage Diff @@
## master #616 +/- ##
==========================================
+ Coverage 99.31% 99.31% +<.01%
==========================================
Files 91 91
Lines 10800 10808 +8
Branches 751 751
==========================================
+ Hits 10726 10734 +8
Misses 56 56
Partials 18 18
Continue to review full report at Codecov.
|
Member
Author
|
I think this is good to go, and I'll rebase #586 on top after it's merged. |
pquentin
approved these changes
Aug 21, 2018
Member
pquentin
left a comment
pquentin
left a comment
There was a problem hiding this comment.
Looks good, but I'm not familiar enough with those low level parts to hit merge right now. Let's wait a bit to see if someone else wants to review this.
Member
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #586