Skip to content

Add Process.stdio as a convenience StapledStream of stdin and stdout#862

Merged
njsmith merged 1 commit intopython-trio:masterfrom
oremanj:subprocess_stdio
Jan 21, 2019
Merged

Add Process.stdio as a convenience StapledStream of stdin and stdout#862
njsmith merged 1 commit intopython-trio:masterfrom
oremanj:subprocess_stdio

Conversation

@oremanj
Copy link
Member

@oremanj oremanj commented Jan 20, 2019

This is intended to make it more ergonomic to speak a back-and-forth protocol with a subprocess.

This is intended to make it more ergonomic to speak a back-and-forth protocol with a subprocess.
@codecov
Copy link

codecov bot commented Jan 20, 2019

Codecov Report

Merging #862 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #862      +/-   ##
==========================================
+ Coverage   99.21%   99.21%   +<.01%     
==========================================
  Files         101      101              
  Lines       12221    12225       +4     
  Branches      894      895       +1     
==========================================
+ Hits        12125    12129       +4     
  Misses         75       75              
  Partials       21       21
Impacted Files Coverage Δ
trio/_subprocess.py 100% <100%> (ø) ⬆️
trio/tests/test_subprocess.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b3c043...41239ab. Read the comment docs.

@oremanj oremanj requested a review from njsmith January 20, 2019 01:43
@njsmith
Copy link
Member

njsmith commented Jan 21, 2019

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants