Skip to content

Mark failing IPython multierror tests as xfail on 3.8 #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njsmith merged 1 commit into from
Feb 5, 2019
Merged

Mark failing IPython multierror tests as xfail on 3.8 #905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions trio/_core/tests/test_multierror.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,10 +593,16 @@ def test_custom_excepthook():
have_ipython = True

need_ipython = pytest.mark.skipif(not have_ipython, reason="need IPython")
# https://github.com/ipython/ipython/issues/11590
fails_on_38 = pytest.mark.xfail(
sys.version_info >= (3, 8),
reason="IPython is currently broken on 3.8-dev"
)


@slow
@need_ipython
@fails_on_38
def test_ipython_exc_handler():
completed = run_script("simple_excepthook.py", use_ipython=True)
check_simple_excepthook(completed)
Expand All @@ -611,6 +617,7 @@ def test_ipython_imported_but_unused():

@slow
@need_ipython
@fails_on_38
def test_ipython_custom_exc_handler():
# Check we get a nice warning (but only one!) if the user is using IPython
# and already has some other set_custom_exc handler installed.
Expand Down