Cancel a cancel scope upon entry if its deadline is in the past#909
Merged
njsmith merged 2 commits intopython-trio:masterfrom Feb 6, 2019
Merged
Cancel a cancel scope upon entry if its deadline is in the past#909njsmith merged 2 commits intopython-trio:masterfrom
njsmith merged 2 commits intopython-trio:masterfrom
Conversation
Fixes python-trio#320. Now that python-trio#901 is implemented, the concerns discussed in python-trio#835 don't apply.
Codecov Report
@@ Coverage Diff @@
## master #909 +/- ##
=========================================
+ Coverage 99.4% 99.4% +<.01%
=========================================
Files 102 102
Lines 12679 12681 +2
Branches 926 927 +1
=========================================
+ Hits 12603 12605 +2
Misses 56 56
Partials 20 20
|
Member
|
Test failure is an intermittent failure in
|
Member
|
OK, so the "Queue" button is a trap. It definitely didn't do what we want. Now I tried clicking the "Rebuild" button that's hidden behind the "..." menu. Maybe that will work better? |
Member
Author
|
It looks like the rerun worked (https://dev.azure.com/python-trio/trio/_build/results?buildId=152) but github didn't notice, so I guess I'll do the close-and-reopen dance. |
Member
|
Hmm, azure's UX could definitely use some improvement here :-) Anyway, the PR seems fine :-). I'm not sure it makes a huge difference either way, but it's certainly a bit closer to what people expect, so why not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #320. Now that #901 is implemented, the concerns discussed in #835 don't apply.