Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1169 1169
Branches 46 46
=========================================
Hits 1169 1169 |
Member
|
Oh shoot, that's tricky. I'm worried about hard-coding a specific version in I'm actually talking to @reaperhulk about the next pyopenssl release right now, for the DTLS stuff -- maybe we can just fix this upstream? |
sethmlarson
approved these changes
Oct 4, 2021
Member
|
This is fixed in pyopenssl main branch now, so I guess our options are:
Next pyopenssl release will be right after pyca/pyopenssl#1026 is merged, and I'm nagging them to review it now, so hopefully soon. |
Member
Author
|
I like doing nothing, so let's wait a bit more. 👍 Thanks for the help and detailed post about our options! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It took me a lot of time to understand that even with our version pins we were using PyOpenSSL's latest intersphinx mapping, and that it was incorrect: pyca/pyopenssl#1046.