Skip to content

Switch from setup.py to pyproject.toml#665

Merged
pquentin merged 5 commits intopython-trio:mainfrom
pquentin:pyproject.toml
Oct 7, 2024
Merged

Switch from setup.py to pyproject.toml#665
pquentin merged 5 commits intopython-trio:mainfrom
pquentin:pyproject.toml

Conversation

@pquentin
Copy link
Member

@pquentin pquentin commented Oct 6, 2024

Based on #664.

@pquentin pquentin requested a review from sethmlarson October 6, 2024 18:10
Copy link

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sethmlarson
Copy link

sethmlarson commented Oct 6, 2024

@pquentin Actually looks like there's a conflict with the latest merge that can't be resolved in the UI, want to take a look on CLI?

@pquentin
Copy link
Member Author

pquentin commented Oct 7, 2024

Thanks! It looks like the deletion of a modified file was the issue here.

@pquentin pquentin merged commit 83ffe51 into python-trio:main Oct 7, 2024
@pquentin pquentin deleted the pyproject.toml branch October 7, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants