Skip to content

Conversation

@martinfleis
Copy link
Collaborator

Closes #1937

@martinfleis martinfleis changed the title CI: include test against ngihtly numpy CI: include test against nightly numpy Apr 25, 2024
@martinfleis
Copy link
Collaborator Author

Once everyone is happy with the approach I took here, I'll mirror it to branca.

@ocefpaf
Copy link
Member

ocefpaf commented Apr 25, 2024

I'm OK with this approach but I'm afraid our tests are not robust enough to catch any failures. The way we use numpy here is unchecked and will produce passing status even when it is wrong. As you confirmed in python-visualization/branca#163.

Copy link
Member

@Conengmo Conengmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Filipe that the code tests probably don't help here. But it doesn't hurt to test against the nightly releases either?

Not sure if I would run the tests a second time. I'd think that makes the output harder to understand. Or is this a temporary addition? In that case it doesn't matter as much.

We might by the way have more success with the notebook/docs selenium tests, as those also check for Javascript errors (or at least I hope that's the case)

@martinfleis
Copy link
Collaborator Author

Not sure if I would run the tests a second time. I'd think that makes the output harder to understand. Or is this a temporary addition? In that case it doesn't matter as much.

Not sure what your suggestion here is then. Split it into two separate runs? Generally, it is better to test against nightly versions of our dependencies, assuming the test will catch issues, so I would try to keep it as permanent. In other projects I maintain, we have dev as another environment alongside the others (latest, oldest...)

@ocefpaf
Copy link
Member

ocefpaf commented May 6, 2024

@martinfleis I can add this later but, if you want to tackle this now, let's add an experimental label to that matrix item to make it easier to find in the logs. I did something like that in https://github.com/Unidata/netcdf4-python/pull/1319/files#diff-83620a0d7a95a32e599b5b5b89eabf1419cb0e3ffb5212d15f87f5bd3a452730R17

@Conengmo
Copy link
Member

Conengmo commented May 6, 2024

Looks good, let's do it!

@ocefpaf ocefpaf merged commit b254797 into python-visualization:main May 6, 2024
@martinfleis martinfleis deleted the nightly-numpy branch May 6, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NumPy 2.0 support

3 participants