-
-
Notifications
You must be signed in to change notification settings - Fork 61
Request review on GitHub when the PR needs change review #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
======================================
Coverage 100% 100%
======================================
Files 20 20
Lines 1557 1663 +106
Branches 87 89 +2
======================================
+ Hits 1557 1663 +106
Continue to review full report at Codecov.
|
brettcannon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One very minor change and a clarifying question based on whether you have live-tested this or not.
Co-Authored-By: Brett Cannon <54418+brettcannon@users.noreply.github.com>
3e1d24c to
69a3deb
Compare
|
Thanks @lysnikolaou for working on this. Would you be able to update the state machine at the top of stage.py to reflect the updated workflow? |
|
@Mariatta I guess I could do that, but I don't understand what you mean by "updated workflow"? If you mean the new GitHub Triagers, then I don't know what the new state should be. |
|
@lysnikolaou I think she means what you're changing with this PR. |
|
@brettcannon @Mariatta The thing is that the state machine should fundamentally remain the same. Maybe we could change the label on the edge |
|
@lysnikolaou yep, probably just the edge label to denote the side-effect that occurs. |
|
@brettcannon I have updated the edge label, that needed tweaking, so the PR might be ready for another review. |
|
LGTM! @Mariatta did you want to do one final review are you okay with merging this? |
|
Sorry I don't have bandwidth to review this at the moment, don't want to block the progress. |
|
@brettcannon Can this be merged as well? |
Co-Authored-By: Brett Cannon <54418+brettcannon@users.noreply.github.com>
|
Thanks for doing this, @lysnikolaou ! |
Upon changing the status to
awaiting change review, a review is also requested through the new GitHub API from the appropriate reviewers.#165