Skip to content

Conversation

@StanFromIreland
Copy link
Member

From mailing list discussion: https://mail.python.org/archives/list/python-buildbots@python.org/thread/CFBDCVYANYZCT3TYKCCEO6QGKQI2XUVD/

I slightly modified @gpshead 's naming suggestion;-)

Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL. try it, see how it goes.

@encukou encukou merged commit cea40ce into python:main Aug 29, 2025
1 check passed
@StanFromIreland StanFromIreland deleted the i-like-puppies branch August 29, 2025 12:41
@jaraco
Copy link
Member

jaraco commented Aug 31, 2025

Any idea how long it takes to propagate to the buildbots? I'm going to test now to see if the setting has taken effect.

@StanFromIreland
Copy link
Member Author

Whenever the buildmaster is restated, I would assume that is done after a commit?

@jaraco
Copy link
Member

jaraco commented Aug 31, 2025

I just ran some tests and unfortunately, some buildbot runners don't yet have the setting.

@encukou
Copy link
Member

encukou commented Sep 1, 2025

Oh, I merged an approved commit without reviewing/testing it, sorry.
test_environ is used in setup, so setting after the call won't have an effect. @StanFromIreland, do you want to fix this?

@StanFromIreland
Copy link
Member Author

test_environ is used in setup

I did not realize, the name is not particularly clear. I will look in to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants