Skip to content

Conversation

@Mariatta
Copy link
Member

@Mariatta Mariatta commented Nov 4, 2017

No description provided.

@Mariatta Mariatta requested review from zooba and zware November 4, 2017 02:58
@Mariatta
Copy link
Member Author

Mariatta commented Nov 4, 2017

I don't know how to tag commits...

@zware
Copy link
Member

zware commented Nov 4, 2017

Lgtm. I'm not sure whether there's a usable way to create a tag from the GitHub UI (GitHub conflates "tag" with "release" and thus might want to do more than just the simple tag that we want), but here's the manual steps:

  1. Merge the PR
  2. Check out the latest sqlite branch
  3. git tag sqlite-3.21.0.0
  4. git push --tags upstream

@Mariatta Mariatta merged commit f0cba0c into python:sqlite Nov 4, 2017
@Mariatta Mariatta deleted the bpo-28791-sqlite branch November 4, 2017 18:27
@Mariatta
Copy link
Member Author

Mariatta commented Nov 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants