Signature of `PyFloat_Pack{2,4,8}` inconsistent with documentation

[ShawnZhong]

According to the documentation (https://docs.python.org/3/c-api/float.html#c.PyFloat_Pack2), the signature of PyFloat_Pack{2,4,8} is

int PyFloat_Pack2(double x, unsigned char *p, int le)

Note that the second parameter is of type unsigned char *

However, for the implementation, the type is actually char *

cpython/Include/cpython/floatobject.h

Line 21 in db20324

PyAPI_FUNC(int) PyFloat_Pack2(double x, char *p, int le);

The commit message of 882d809, says "Replace the "unsigned char*" type with "char*" which is more common and easy to use". So the fix is to update the docs to use char * as well.

Linked PRs

• gh-136663: fix signatures of PyFloat_Pack/Unpack[248] in docs #136664
• [3.14] gh-136663: fix signatures of PyFloat_Pack/Unpack in docs (GH-136664) #136666
• [3.13] gh-136663: fix signatures of PyFloat_Pack/Unpack in docs (GH-136664) #136667

[skirpichev]

Thanks. PR is ready: #136664

[ShawnZhong]

Wow that’s fast, thanks!