Implement unix read_pipe.is_reading() method

[asvetlov]

BPO	38314
Nosy	@asvetlov, @1st1, @progmatic-99, @CallumQuick, @benedwards14
PRs	bpo-38314: Add is_reading() method to asyncio _UnixReadPipeTransport #17042 bpo-38314: Add is_reading() method to asyncio _UnixReadPipeTransport #17755

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2019-09-29.11:22:13.562>
labels = ['easy', 'type-feature', '3.9', 'expert-asyncio']
title = 'Implement unix read_pipe.is_reading() method'
updated_at = <Date 2019-12-30.13:53:39.286>
user = 'https://github.com/asvetlov'

bugs.python.org fields:

activity = <Date 2019-12-30.13:53:39.286>
actor = 'callumquick'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['asyncio']
creation = <Date 2019-09-29.11:22:13.562>
creator = 'asvetlov'
dependencies = []
files = []
hgrepos = []
issue_num = 38314
keywords = ['patch', 'newcomer friendly']
message_count = 7.0
messages = ['353494', '353495', '353499', '353500', '355465', '355484', '355939']
nosy_count = 5.0
nosy_names = ['asvetlov', 'yselivanov', 'shubh07', 'callumquick', 'benedwards14']
pr_nums = ['17042', '17755']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue38314'
versions = ['Python 3.9']

[asvetlov]

Sockets support it, there is no reason for missing the method in unix pipe.

[asvetlov]

The issue is easy, basically we need the following code plus a test

    def is_reading(self):
        return not self._paused and not self._closing

[progmatic-99]

I would like to take this up. I am a beginner and any more instructions you want to give me.

[asvetlov]

Nothing special.
There is UnixReadPipeTransportTests test cases inside Lib/test/test_asyncio/test_unix_events.py

This class has a bunch of tests for pause_reading() / resume_reading().

Test(s) for is_reading() can be built in the same way.

[benedwards14]

Shubham are you still interested in this, or are you ok with me taking it on?

[asvetlov]

Please do.

[callumquick]

I've agreed with Ben that I'll look at making the necessary changes today.