Skip to content

[2.7] bpo-32804: Include the context parameter in urlretrieve documentation #10203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhangyangyu merged 3 commits into from
Nov 1, 2018
Merged

[2.7] bpo-32804: Include the context parameter in urlretrieve documentation #10203

zhangyangyu merged 3 commits into from
Nov 1, 2018

Conversation

@lysnikolaou
Copy link
Member

@lysnikolaou lysnikolaou commented Oct 28, 2018 •
edited
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 28, 2018
@lysnikolaou lysnikolaou changed the title bpo-32804: Include the context parameter in urlretrieve documentation [2.7] bpo-32804: Include the context parameter in urlretrieve documentation Oct 28, 2018
@lysnikolaou
Copy link
Member Author

lysnikolaou commented Oct 29, 2018

I note that most of the existing raw text is word-wrapped around the 79 column mark, but some of the new text isn't.

Done!

zhangyangyu
zhangyangyu reviewed Oct 30, 2018
View reviewed changes
Doc/library/urllib.rst Outdated
Copy link
Member

@zhangyangyu zhangyangyu Oct 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two spaces after period please. And it looks to me a versionchanged note is also lacked in URLopener?

Copy link
Member Author

@lysnikolaou lysnikolaou Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the spaces in urlretrieve and added a versionchanged in URLopener. I also fixed the spaces and the wrapping in the versionchanged of urlopen, which was not consistent to what you suggested.

@zhangyangyu zhangyangyu merged commit aa39c1a into python:2.7 Nov 1, 2018
@lysnikolaou lysnikolaou deleted the bpo32804 branch November 4, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhangyangyu zhangyangyu zhangyangyu left review comments

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lysnikolaou @zhangyangyu @the-knights-who-say-ni @bedevere-bot