Skip to content

gh-89891: Refer SharedMemory implementation as POSIX #104678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 2 commits into from
Feb 1, 2024
Merged

gh-89891: Refer SharedMemory implementation as POSIX #104678

serhiy-storchaka merged 2 commits into from
Feb 1, 2024

Conversation

@arhadthedev
Copy link
Member

@arhadthedev arhadthedev commented May 20, 2023 •
edited by github-actions bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 20, 2023
Closed
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels May 20, 2023
@arhadthedev arhadthedev marked this pull request as ready for review May 20, 2023 07:31
@arhadthedev arhadthedev requested a review from tiran as a code owner May 20, 2023 07:32
@arhadthedev arhadthedev added the needs backport to 3.11 only security fixes label May 20, 2023
@arhadthedev
Copy link
Member Author

arhadthedev commented May 23, 2023

Could anybody review and possibly merge this PR, please?

@arhadthedev arhadthedev added the needs backport to 3.12 only security fixes label May 23, 2023
@arhadthedev arhadthedev removed the request for review from tiran May 27, 2023 16:31
@arhadthedev
Copy link
Member Author

arhadthedev commented Jun 12, 2023

@applio (as an author of the affected line), @pitrou, @gpshead (as multiprocessing module experts)

@arhadthedev arhadthedev requested a review from gpshead as a code owner February 1, 2024 19:51
serhiy-storchaka
serhiy-storchaka approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is right. It only uses shm_open() and shm_unlink() which are in POSIX. System V specific functions are not used.

LGTM.

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) February 1, 2024 19:56
@serhiy-storchaka serhiy-storchaka merged commit 500ede0 into python:main Feb 1, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Feb 1, 2024

Thanks @arhadthedev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 1, 2024
@arhadthedev @miss-islington
pythongh-89891: Refer SharedMemory implementation as POSIX (pythonGH-…
256942c 
…104678)

It only uses POSIX API.
(cherry picked from commit 500ede0)

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
@bedevere-app
Copy link

bedevere-app bot commented Feb 1, 2024

GH-114873 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 1, 2024
@arhadthedev @miss-islington
pythongh-89891: Refer SharedMemory implementation as POSIX (pythonGH-…
606eb8d 
…104678)

It only uses POSIX API.
(cherry picked from commit 500ede0)

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 1, 2024
@bedevere-app
Copy link

bedevere-app bot commented Feb 1, 2024

GH-114874 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 1, 2024
serhiy-storchaka pushed a commit that referenced this pull request Feb 1, 2024
@miss-islington @arhadthedev
[3.11] gh-89891: Refer SharedMemory implementation as POSIX (GH-104678)…
3c30de1 
… (GH-114874)

It only uses POSIX API.
(cherry picked from commit 500ede0)

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
serhiy-storchaka pushed a commit that referenced this pull request Feb 1, 2024
@miss-islington @arhadthedev
[3.12] gh-89891: Refer SharedMemory implementation as POSIX (GH-104678)…
8dcf4fb 
… (GH-114873)

It only uses POSIX API.
(cherry picked from commit 500ede0)

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@arhadthedev @aisk
pythongh-89891: Refer SharedMemory implementation as POSIX (pythonGH-…
2048885 
…104678)

It only uses POSIX API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arhadthedev @serhiy-storchaka @bedevere-bot