Skip to content

gh-104638: make TarFile.extraction_filter future release references more clear #109908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hadrizi wants to merge 1 commit into from
Closed

gh-104638: make TarFile.extraction_filter future release references more clear #109908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Doc/library/tarfile.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ be finalized; only the internally used file object will be closed. See the
and fall back to the :func:`fully_trusted <fully_trusted_filter>` filter,
whose dangerous behavior matches previous versions of Python.

In Python 3.14+, leaving ``extraction_filter=None`` will cause
In Python 3.14, leaving ``extraction_filter=None`` will cause
Copy link
Contributor

@nineteendo nineteendo May 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that a bit redundant?

Suggested change
In Python 3.14, leaving ``extraction_filter=None`` will cause
Leaving ``extraction_filter=None`` will cause

And can't we merge this with the previous paragraph?

extraction methods to use the :func:`data <data_filter>` filter by default.

The attribute may be set on instances or overridden in subclasses.
Expand Down