Skip to content

Conversation

@sobolevn
Copy link
Member

No description provided.

@hugovk
Copy link
Member

hugovk commented Nov 12, 2023

Any pressing need to bump mypy ruff?

I know we don't need to bump sphinx-lint because I just released it a few minutes ago and it's a bugfix we don't need.

@AlexWaygood
Copy link
Member

I agree with @hugovk -- I think we can probably slow down the rate of version bumps for pre-commit/mypy etc. :)

CPython is a big project with lots of contributors; adding to the number of open PRs unnecessarily creates extra noise and churn for other people trying to keep track of what's going on. In general, I think it's probably okay to bump these every few months rather than every few weeks.

If there's a specific reason to bump a certain dependency sooner, then that's a different question -- e.g. I bumped mypy a few days ago because I knew running mypy on Tools/clinic/ would fail with the latest version of mypy, and I wanted to fix that: #111961. But in general, I think we should slow the pace of these version bumps a bit.

@hugovk
Copy link
Member

hugovk commented Nov 13, 2023

As mentioned elsewhere, I'd like to use https://pre-commit.ci to automate updating (either monthly or quarterly; weekly is too frequent), but it warrants a discussion whether we also want it to autofix PRs.

However, I just checked and we can set autofix_prs to false to prevent that: https://pre-commit.ci/#configuration

@AlexWaygood
Copy link
Member

This is now out of date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants