Skip to content

bpo-26669: Reject float infinity in time functions #11507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vstinner wants to merge 1 commit into from
Closed

bpo-26669: Reject float infinity in time functions #11507

vstinner wants to merge 1 commit into from

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jan 10, 2019 •
edited by bedevere-bot
Loading

bpo-26669, bpo-35707: Reject -inf and +inf floats in the following C
functions:

  • _PyTime_ObjectToDenominator()
  • _PyTime_ObjectToTime_t()
  • _PyTime_FromSecondsObject()
  • _PyTime_FromMillisecondsObject()

https://bugs.python.org/issue26669

@vstinner
bpo-26669: Reject float infinity in time functions
aaea5b2 
bpo-26669, bpo-35707: Reject -inf and +inf floats in the following C
functions:

* _PyTime_ObjectToDenominator()
* _PyTime_ObjectToTime_t()
* _PyTime_FromSecondsObject()
* _PyTime_FromMillisecondsObject()
@vstinner vstinner requested a review from gpshead January 10, 2019 16:49
@vstinner
Copy link
Member Author

vstinner commented Jan 10, 2019

Currently, passing float("inf") fail with OverflowError("timestamp too large to convert to C _PyTime_t"). With this change, ValueError("invalid value: infinity") is raised explicitly.

... I'm not sure that it's really worth it / the correct behavior.

@vstinner
Copy link
Member Author

vstinner commented Apr 16, 2019

I lost track of this issue and so I close it.

@vstinner vstinner closed this Apr 16, 2019
@vstinner vstinner deleted the pytime_inf branch April 16, 2019 15:39
@jdemeyer jdemeyer mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot