gh-100746: Improve test_named_expressions.py#116713
Merged
sobolevn merged 1 commit intopython:mainfrom Mar 13, 2024
Merged
Conversation
emilyemorehouse
approved these changes
Mar 13, 2024
Member
emilyemorehouse
left a comment
emilyemorehouse
left a comment
There was a problem hiding this comment.
Looks great, thanks for getting more test coverage on this!
sobolevn
added
needs backport to 3.11
Member
Author
|
Backport to 3.12 will be as-is, while 3.11 will be much smaller, because 3.11 does not have new binding logic from 3.12 |
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 13, 2024
(cherry picked from commit 25684e7) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-116747 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 13, 2024
(cherry picked from commit 25684e7) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-116748 is a backport of this pull request to the 3.11 branch. |
sobolevn
added a commit
that referenced
this pull request
Mar 13, 2024
vstinner
pushed a commit
to vstinner/cpython
that referenced
this pull request
Mar 20, 2024
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two major changes:
passwhere possible and instead used an assert for what we expect to happendicthas key and value, we need to be sure that both work correctly.test_named_expressions.py#100746