bpo-35843: Implement __getitem__ for _NamespacePath #11690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamanu
approved these changes
Jan 29, 2019
Contributor
eamanu
left a comment
eamanu
left a comment
There was a problem hiding this comment.
LGTM. I re run the sample used on bpo https://bugs.python.org/issue35843 and have the expected behavior.
asottile
force-pushed
the
bpo_35843_NamespacePath_Sized
branch
from
5550ff6 to
0de7e75
Compare
Contributor
Author
|
@serhiy-storchaka should be good to review again -- thanks for the tip 👍 |
Member
|
I can say nothing about whether this idea is good or bad. But technically this PR looks correct. |
brettcannon
approved these changes
Mar 1, 2019
Member
|
I'm blocking this to see if any other core devs have an opinion on this on the issue tracker, otherwise it LGTM! |
Contributor
Author
|
@brettcannon given the +1 in the bpo issue I think this is good to go |
Member
|
@asottile that's the plan 😄 Just need to find the time to handle the merge (probably tomorrow/Friday). |
Member
|
Thanks, @asottile ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.