gh-117348: Refactored RawConfigParser._read for simplicity and comprehensibility#117372

Merged

jaraco merged 23 commits intopython:mainfrom

jaraco:feature/refactor-configparser-read-complexity

Mar 29, 2024

Commits on Mar 29, 2024

Extract method for _read_inner, reducing complexity and indentation by 1.
jaraco
committed
Extract method for _raise_all and yield ParseErrors from _read_inner.
jaraco
committed
Prefer iterators to splat expansion and literal indexing.
jaraco
committed
Extract method for _strip_comments. Reduces complexity by 7.
jaraco
committed
Model the file lines in a class to encapsulate the comment status and cleaned value.
jaraco
committed
Encapsulate the read state as a dataclass
jaraco
committed
Extract _handle_continuation_line and _handle_rest methods. Reduces complexity by 8.
jaraco
committed
Reindent
jaraco
committed
At least for now, collect errors in the ReadState
jaraco
committed
Check for missing section header separately.
jaraco
committed
Extract methods for _handle_header and _handle_option. Reduces complexity by 6.
jaraco
committed
Remove unreachable code. Reduces complexity by 4.
jaraco
committed
Remove unreachable branch
jaraco
committed
Handle error condition early. Reduces complexity by 1.
jaraco
committed
Add blurb
jaraco
committed
Move _raise_all to ParsingError, as its behavior is most closely related to the exception class and not the reader.
jaraco
committed
Split _strip* into separate methods.
jaraco
committed
Refactor _strip_full to compute the strip just once and use 'not any' to determine the factor.
jaraco
committed
Replace use of 'sys.maxsize' with direct computation of the stripped value.
jaraco
committed
Extract has_comments as a dynamic property.
jaraco
committed
Implement clean as a cached property.
jaraco
committed
Model comment prefixes in the RawConfigParser within a prefixes namespace.
jaraco
committed
Use a regular expression to search for the first match.
jaraco
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

gh-117348: Refactored RawConfigParser._read for simplicity and comprehensibility#117372

gh-117348: Refactored RawConfigParser._read for simplicity and comprehensibility#117372
jaraco merged 23 commits intopython:mainfrom
jaraco:feature/refactor-configparser-read-complexity

Commits on Mar 29, 2024

Extract method for _read_inner, reducing complexity and indentation by 1.

Extract method for _raise_all and yield ParseErrors from _read_inner.

Prefer iterators to splat expansion and literal indexing.

Extract method for _strip_comments. Reduces complexity by 7.

Model the file lines in a class to encapsulate the comment status and cleaned value.

Encapsulate the read state as a dataclass

Extract _handle_continuation_line and _handle_rest methods. Reduces complexity by 8.

Reindent

At least for now, collect errors in the ReadState

Check for missing section header separately.

Extract methods for _handle_header and _handle_option. Reduces complexity by 6.

Remove unreachable code. Reduces complexity by 4.

Remove unreachable branch

Handle error condition early. Reduces complexity by 1.

Add blurb

Move _raise_all to ParsingError, as its behavior is most closely related to the exception class and not the reader.

Split _strip* into separate methods.

Refactor _strip_full to compute the strip just once and use 'not any' to determine the factor.

Replace use of 'sys.maxsize' with direct computation of the stripped value.

Extract has_comments as a dynamic property.

Implement clean as a cached property.

Model comment prefixes in the RawConfigParser within a prefixes namespace.

Use a regular expression to search for the first match.

Uh oh!

gh-117348: Refactored RawConfigParser._read for simplicity and comprehensibility#117372jaraco merged 23 commits intopython:mainpython/cpython:mainfrom jaraco:feature/refactor-configparser-read-complexityjaraco/cpython:feature/refactor-configparser-read-complexityCopy head branch name to clipboard

Commits

Commits on Mar 29, 2024

gh-117348: Refactored RawConfigParser._read for simplicity and comprehensibility#117372
jaraco merged 23 commits intopython:mainfrom
jaraco:feature/refactor-configparser-read-complexity