WIP: bpo-36347: Renaming the constants for the PyMemberDef.flags #12527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Declaration of new constants for the PyMemberDef.flags with an enumeration and with the PY_ prefix (convention of the C-API for the public names). The redeclaration is for the backward compatibility. * Use __attribute__(deprecate) for the deprecation of the former constants. * Update the documentation about the new constants.
Member
Author
|
This PR is a WIP PR and it's used for the associated issue. Checklist
|
matrixise
changed the title
jdemeyer
requested changes
Mar 27, 2019
Contributor
jdemeyer
left a comment
jdemeyer
left a comment
There was a problem hiding this comment.
The whole "restricted mode" thing is long obsolete and support has been removed in Python 3. So really, the flags related to restricted mode should just be deprecated without offering a replacement. And I would propose to remove all mentions of restricted mode from the docs.
Member
Author
|
On 03/27, Jeroen Demeyer wrote:
jdemeyer requested changes on this pull request.
The whole "restricted mode" thing is long obsolete and support has been
removed in Python 3. So really, the flags related to restricted mode
should just be deprecated *without* offering a replacement. And I would
propose to remove all mentions of restricted mode from the docs.
Hi Jeroen,
Sorry, I didn't see your previous email.
About this point, I have to send an email to python-dev@python.org and
ask for the next step for this issue.
Thank you for your suggestion.
Have a nice day
|
Contributor
|
See also #12684 for no longer using these constants in CPython internally. That PR should be completely uncontroversial. |
Member
Author
|
I close my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enumeration and with the PY_ prefix (convention of the C-API for the
public names). The redeclaration is for the backward compatibility.
constants.
https://bugs.python.org/issue36347